Can't remove and replace WhatPub link

[ROBCamra]

Likewise de-listed CAMRA Heritage Pubs, e.g.: The Englefield

A dwarf informed me that such redundant links can't be removed.

Correct, we don't have a button to remove it.

[Dave M]

I think the historic interior links are all now updated

[Quinno]

County Hotel now working, thanks Dave!!

Now, about this one... http://forums.pubsgalore.co.uk/showt...nd-closed-pubs

[sheffield hatter]

I think the historic interior links are all now updated

I had a look at the one that Tris mentioned : The Englefield

The heritage link has gone, but so has the WhatPub link. I tried to restore the latter, but it failed to paste. (WhatPub has it as Engle Field - two words - but that can't be the reason why pasting the link failed to work.) As a test, I've deleted and successfully restored a WhatPub link on a pub that is still listed on the heritage website.

[Dave M]

County Hotel now working, thanks Dave!!

Now, about this one... http://forums.pubsgalore.co.uk/showt...nd-closed-pubs

Yes something not right about my code logic. I think it stopped working when I was forced to make a small database change but I've been looking through my code and struggling to understand how it ever worked.

[Dave M]

I had a look at the one that Tris mentioned : The Englefield

The heritage link has gone, but so has the WhatPub link. I tried to restore the latter, but it failed to paste. (WhatPub has it as Engle Field - two words - but that can't be the reason why pasting the link failed to work.) As a test, I've deleted and successfully restored a WhatPub link on a pub that is still listed on the heritage website.

Some people are never satisfied!

Thanks for pointing it out. I was fairly confident that I had removed all the historic interiors links, I wasn't confident that I hadn't broken anything along the way. So my new code said to not show any sort of WhatPub link if a pub used to have a historic interior.

[Quinno]

I've been looking through my code and struggling to understand how it ever worked.

I can relate.

[sheffield hatter]

Some people are never satisfied!

Thanks for pointing it out. I was fairly confident that I had removed all the historic interiors links, I wasn't confident that I hadn't broken anything along the way. So my new code said to not show any sort of WhatPub link if a pub used to have a historic interior.

I apologise for being so helpful.

[Quinno]

Whac-A-Mole code bug.

It looks like the addition of web links is now showing up in the user's own contributions page. I added a bunch for Pwlhelli area pubs a couple of days ago and they are showing up on my contributions.

contribs.JPG

I recall a debate many years ago where we asked for this not to happen as it was seen as being second-order - people only wanted to see pubs listed where they'd coloured-in one of the available icons. Also when you're researching for a future trip it means the pub then gets buried in the list when you come round to review it.

Could you have a look please...

[sheffield hatter]

Some people are never satisfied!

Which reminds me...

When Camra reassessed their heritage pub interior inventory they introduced a new listing called OCR - outstanding conversions and restorations (Here's an example: The Angel). Would it be any trouble to adapt your coding to pick these up too?

Thanks ever so.